Show skill indicator in session view when triggered#358
Open
TechWizard9999 wants to merge 1 commit intodifferent-ai:devfrom
Open
Show skill indicator in session view when triggered#358TechWizard9999 wants to merge 1 commit intodifferent-ai:devfrom
TechWizard9999 wants to merge 1 commit intodifferent-ai:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Member
|
would appreciate a small gif screenshot to help get this in faster (+ seems there's a merge conflict) thx for the pr! |
Contributor
Author
|
Hi @benjaminshafii , I have updated and verified it also resolved merge conflict
I've attached a recording showing the indicator and the screenshot Please check this and let me know if you want any changes |
Contributor
Author
|
Hi @benjaminshafii , |
Contributor
Author
|
Hi @benjaminshafii , |
b6f8cf2 to
c9f86c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Shows a clear purple indicator with skill name in the session view when a skill is triggered.
Closes #274
Approach
tool === "skill"activeSkill()memo reads tool metadata/title for skill nameChanges
packages/app/src/app/pages/session.tsx- Added skill indicator logic and UIpackages/app/src/app/app.tsx- Fixed undefinedisDemoMode()referenceTesting
Build Verification
pnpm typecheckpasses with no errorspnpm build:uicompletes successfullyManual Testing
pnpm dev:uistarts without errorsCode Review